ValidateSwap()

bool ValidateSwap ( inout Serializer ctx, InventoryValidation validation )

protected

kumarjac: This indicates a failure in replication relationships as player full inventory should be synchronized always if player exists on the remote

Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

Check if this this is being executed on the server and not by a juncture or AI

Continuing on with execution of rest of the function

Check whether the juncture for the related player and items has been acquired.

См. определение в файле DayZPlayerInventory.c строка 2357

    {
        DayZPlayer playerOwner = GetDayZPlayerOwner();
        InventoryJunctureSwapValidation swapValidation = new InventoryJunctureSwapValidation(ctx);
        if (!swapValidation)
            return false;
 
        array<EntityAI> itemsToRepair;
        InventoryLocation repairIl;
 
        #ifdef ENABLE_LOGGING
        if (LogManager.IsInventoryMoveLogEnable())
        {
            Debug.InventoryMoveLog("STS = " + playerOwner.GetSimulationTimeStamp() + " src1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src1) + " dst1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst1) + " src2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src2) + " dst2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst2), "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );  
        }
        #endif
                        
        if (validation.m_IsRemote && (!swapValidation.m_SrcItem1 || !swapValidation.m_SrcItem2))
        {
            if (!swapValidation.m_SrcItem2 && swapValidation.m_SrcItem1) 
            {
                // Treat as a simple move of srcItem1 to dst1 on remote clients
                LocationSyncMoveEntity(swapValidation.m_Src1, swapValidation.m_Dst1);
                validation.m_Result = InventoryValidationResult.SUCCESS;
                return true;
            }
            else if (!swapValidation.m_SrcItem1 && swapValidation.m_SrcItem2) 
            {
                // Treat as a simple move of srcItem2 to dst2 on remote clients
                LocationSyncMoveEntity(swapValidation.m_Src2, swapValidation.m_Dst2);
                validation.m_Result = InventoryValidationResult.SUCCESS;
                return true;
            }
            else
            {
                if (swapValidation.m_SkippedSwap)
                {
                    #ifdef ENABLE_LOGGING
                    if (LogManager.IsInventoryMoveLogEnable())
                    {
                        Debug.InventoryMoveLog("Remote - skipped", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );
                    }
                    #endif
                }
                else
                {
                    #ifdef ENABLE_LOGGING
                    if (LogManager.IsInventoryMoveLogEnable())
                    {
                        Debug.InventoryMoveLog("Failed - item1 or item2 not exist", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );
                    }
                    #endif
    
                    Error("[syncinv] HandleInputData remote input (cmd=SWAP) dropped, item not in bubble");
                }
            }
 
            return true;
        }
                
        EnableMovableOverride(swapValidation.m_SrcItem1);
        EnableMovableOverride(swapValidation.m_SrcItem2);
 
        if (swapValidation.m_Success && !validation.m_IsRemote && !validation.m_IsJuncture && (swapValidation.m_SrcItem1 != swapValidation.m_DstItem1 || swapValidation.m_SrcItem2 != swapValidation.m_DstItem2) )
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                if(swapValidation.m_SrcItem1 != swapValidation.m_DstItem1)
                    Debug.InventoryMoveLog("Failed - src and dst are for different for first item", "SWAP" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                if(swapValidation.m_SrcItem2 != swapValidation.m_DstItem2)
                    Debug.InventoryMoveLog("Failed - src and dst are for different for second item", "SWAP" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
 
            if (LogManager.IsSyncLogEnable())
            {
                if(swapValidation.m_SrcItem1 != swapValidation.m_DstItem1)
                    syncDebugPrint("[syncinv] HandleInputData Failed - first src and dst are for different items src item =" + swapValidation.m_SrcItem1 + " dst item =" + swapValidation.m_DstItem1);
                if(swapValidation.m_SrcItem2 != swapValidation.m_DstItem2)
                    syncDebugPrint("[syncinv] HandleInputData Failed - second src and dst are for different items src item =" + swapValidation.m_SrcItem1 + " dst item =" + swapValidation.m_DstItem1);
            }
            #endif
 
            if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                swapValidation.m_Success = false;
            }
            else
            {
                return true;
            }
        }
        
        if (swapValidation.m_Success && !validation.m_IsRemote && !validation.m_IsJuncture && !PlayerCheckRequestSrc(swapValidation.m_Src1, GameInventory.c_MaxItemDistanceRadius))
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - CheckRequestSrc1", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );
            }
            
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[cheat] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " failed src1 check with cmd=" + typename.EnumToString(InventoryCommandType, InventoryCommandType.SWAP) + " src1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src1));
            }
            #endif
            
            RemoveMovableOverride(swapValidation.m_SrcItem1);
            RemoveMovableOverride(swapValidation.m_SrcItem2);
            
            if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                swapValidation.m_Success = false;
                #ifdef DIAG_DEVELOPER
                if (PluginInventoryDebug.Cast(GetPlugin(PluginInventoryDebug)).IsDesyncRepairEnable())
                {
                #endif
                    itemsToRepair = new array<EntityAI>;
                    repairIl = new InventoryLocation;
    
                    swapValidation.m_SrcItem1.GetInventory().GetCurrentInventoryLocation(repairIl);
                    
                    if(swapValidation.m_Src1 != repairIl)
                    {
                        itemsToRepair.Insert(swapValidation.m_SrcItem1);
                    }
    
                    swapValidation.m_SrcItem2.GetInventory().GetCurrentInventoryLocation(repairIl);
                    if(swapValidation.m_Src2 != repairIl)
                    {
                        itemsToRepair.Insert(swapValidation.m_SrcItem2);
                    }
    
                    if (itemsToRepair.Count())
                    {
                        InventoryInputUserData.SendServerInventoryCheck(itemsToRepair, GetDayZPlayerOwner());
                    }
                #ifdef DIAG_DEVELOPER
                }
                #endif
            }
            else
            {
                return true;
            }
        }

        if (swapValidation.m_Success && !validation.m_IsRemote && !validation.m_IsJuncture && !PlayerCheckRequestSrc(swapValidation.m_Src2, GameInventory.c_MaxItemDistanceRadius))
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - CheckRequestSrc2", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );
            }
            
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[cheat] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " failed src2 check with cmd=" + typename.EnumToString(InventoryCommandType, InventoryCommandType.SWAP) + " src2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src2));
            }
            #endif
            
            RemoveMovableOverride(swapValidation.m_SrcItem1);
            RemoveMovableOverride(swapValidation.m_SrcItem2);
            
            if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                swapValidation.m_Success = false;
                #ifdef DIAG_DEVELOPER
                if (PluginInventoryDebug.Cast(GetPlugin(PluginInventoryDebug)).IsDesyncRepairEnable())
                {
                #endif
                    itemsToRepair = new array<EntityAI>;
                    repairIl = new InventoryLocation;
    
                    swapValidation.m_SrcItem2.GetInventory().GetCurrentInventoryLocation(repairIl);
                    if(swapValidation.m_Src2 != repairIl)
                    {
                        itemsToRepair.Insert(swapValidation.m_SrcItem2);
                    }
    
                    if (itemsToRepair.Count())
                    {
                        InventoryInputUserData.SendServerInventoryCheck(itemsToRepair, GetDayZPlayerOwner());
                    }
                #ifdef DIAG_DEVELOPER
                }
                #endif
            }
            else
            {
                return true;
            }
        }

        if (swapValidation.m_Success && !validation.m_IsRemote && !validation.m_IsJuncture && !PlayerCheckSwapItemsRequest(swapValidation.m_Src1, swapValidation.m_Src2, swapValidation.m_Dst1, swapValidation.m_Dst2, GameInventory.c_MaxItemDistanceRadius))
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - CheckSwapItemsRequest", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString());
            }
            
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[cheat] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " is cheating with cmd=" + typename.EnumToString(InventoryCommandType, InventoryCommandType.SWAP) + " src1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src1) + " src2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src2) +  " dst1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst1) + " dst2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst2));
            }
            #endif
            
            RemoveMovableOverride(swapValidation.m_SrcItem1);
            RemoveMovableOverride(swapValidation.m_SrcItem2);
            
            if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                swapValidation.m_Success = false;
            }
            else
            {
                return true;
            }
        }
 
        RemoveMovableOverride(swapValidation.m_SrcItem1);
        RemoveMovableOverride(swapValidation.m_SrcItem2);
        
        if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_CLIENT)
        {
            ClearInventoryReservationEx(swapValidation.m_DstItem1, swapValidation.m_Dst1);
            ClearInventoryReservationEx(swapValidation.m_DstItem2, swapValidation.m_Dst2);
        }
        
        if (swapValidation.m_Success && !validation.m_IsRemote && !GameInventory.CanForceSwapEntitiesEx(swapValidation.m_SrcItem1, swapValidation.m_Dst1, swapValidation.m_SrcItem2, swapValidation.m_Dst2))
        {
        #ifdef ENABLE_LOGGING   
            #ifdef DEVELOPER
            DumpInventoryDebug();
            #endif
                
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - CanForceSwapEntitiesEx", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString());
            }
        #endif
            
            if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                if (swapValidation.m_Dst1)
                    SendRepairToClientDst(swapValidation.m_Dst1);
 
                if (swapValidation.m_Dst2)
                    SendRepairToClientDst(swapValidation.m_Dst2);
                swapValidation.m_Success = false;
            }
            else
            {
                Error("[desync] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " CANNOT swap cmd=" + typename.EnumToString(InventoryCommandType, InventoryCommandType.SWAP) + " src1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src1) + " dst1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst1) +" | src2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src2) + " dst2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst2));
                return true;
            }
        }
    
        if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_CLIENT)
        {
            AddInventoryReservationEx(swapValidation.m_DstItem1, swapValidation.m_Dst1, GameInventory.c_InventoryReservationTimeoutShortMS);
            AddInventoryReservationEx(swapValidation.m_DstItem2, swapValidation.m_Dst2, GameInventory.c_InventoryReservationTimeoutShortMS);
        }
 
        if (!(swapValidation.m_Src1.IsValid() && swapValidation.m_Src2.IsValid() && swapValidation.m_Dst1.IsValid() && swapValidation.m_Dst2.IsValid()))
        {
            Error("HandleInputData: cmd=" + typename.EnumToString(InventoryCommandType, InventoryCommandType.SWAP) + " invalid input(s): src1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src1) + " src2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Src2) +  " dst1=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst1) + " dst2=" + InventoryLocation.DumpToStringNullSafe(swapValidation.m_Dst2));
            return true;
        }
        
        if (playerOwner.GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
        {
            if (!validation.m_IsJuncture)
            {
                JunctureRequestResult resultSwap = TryAcquireTwoInventoryJuncturesFromServer(playerOwner, swapValidation.m_Src1, swapValidation.m_Src2, swapValidation.m_Dst1, swapValidation.m_Dst2);
                if (resultSwap == JunctureRequestResult.JUNCTURE_NOT_REQUIRED)
                {
                    #ifdef ENABLE_LOGGING
                    if (LogManager.IsInventoryMoveLogEnable())
                    {
                        Debug.InventoryMoveLog("Juncture not required", "SWAP" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString());
                    }
                    #endif
    
                }
                else if (swapValidation.m_Success && resultSwap == JunctureRequestResult.JUNCTURE_ACQUIRED)
                {
                    #ifdef ENABLE_LOGGING
                    if (LogManager.IsInventoryMoveLogEnable())
                    {
                        Debug.InventoryMoveLog("Juncture sended", "SWAP" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                    }
                    #endif
                    
                    validation.m_Result = InventoryValidationResult.JUNCTURE;
                    EnableMovableOverride(swapValidation.m_SrcItem1);
                    EnableMovableOverride(swapValidation.m_SrcItem2);
                    return true;
                }
                else
                {
                    #ifdef ENABLE_LOGGING
                    if (LogManager.IsInventoryMoveLogEnable())
                    {
                        Debug.InventoryMoveLog("Juncture denied", "SWAP" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                    }
                    #endif
                    
                    validation.m_Result = InventoryValidationResult.FAILED;
                    validation.m_Reason = InventoryValidationReason.JUNCTURE_DENIED;
                    return true;
                }
            }
            else if (validation.m_IsJuncture)
            {
                bool hasJuncture = false;
                int nonNullCount = 0;
                bool failed = false;
                
                if (swapValidation.m_SrcItem1 != null)
                {
                    nonNullCount++;
                    if (!g_Game.HasInventoryJuncture(playerOwner, swapValidation.m_SrcItem1))
                        failed = true;
                }
                
                if (!failed && swapValidation.m_SrcItem2 != null)
                {
                    nonNullCount++;
                    if (!g_Game.HasInventoryJuncture(playerOwner, swapValidation.m_SrcItem2))
                        failed = true;
                }
                
                if (!failed && swapValidation.m_DstItem1 != null)
                {
                    nonNullCount++;
                    if (!g_Game.HasInventoryJuncture(playerOwner, swapValidation.m_DstItem1))
                        failed = true;
                }
                
                if (!failed && swapValidation.m_DstItem2 != null)
                {
                    nonNullCount++;
                    if (!g_Game.HasInventoryJuncture(playerOwner, swapValidation.m_DstItem2))
                        failed = true;
                }
                
                hasJuncture = (nonNullCount > 0 && !failed);
    
                if (!hasJuncture) 
                {
#ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - missing juncture", "SWAP", "n/a", "ValidateSwap", GetDayZPlayerOwner().ToString() );
            }
#endif
                    swapValidation.m_Success = false;
                }       
            }
        }
        
        if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_CLIENT)
        {
            ClearInventoryReservationEx(swapValidation.m_DstItem1, swapValidation.m_Dst1);
            ClearInventoryReservationEx(swapValidation.m_DstItem2, swapValidation.m_Dst2);
        }
        else
        {
            g_Game.ClearJunctureEx(playerOwner, swapValidation.m_DstItem1);
            g_Game.ClearJunctureEx(playerOwner, swapValidation.m_DstItem2);
        }
        
        //TODO: hotfix solution
        if (!validation.m_IsRemote && validation.m_IsJuncture && !SwapCheckExclusionMaskLocal(swapValidation.m_Src1, swapValidation.m_Src2, swapValidation.m_Dst1, swapValidation.m_Dst2))
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - !SwapCheckExclusionMaskLocal - condition failed locally", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );
            }
            #endif
            return false;
        }
        
        #ifdef ENABLE_LOGGING
        if (LogManager.IsInventoryMoveLogEnable())
        {
            Debug.InventoryMoveLog("Success - item swap", "SWAP" , "n/a", "ProcessInputData", playerOwner.ToString() );
        }
        #endif
 
        if (swapValidation.m_Success)
        {
            bool isNotSkipped = LocationSwap(swapValidation.m_Src1, swapValidation.m_Src2, swapValidation.m_Dst1, swapValidation.m_Dst2);
            ctx = new ScriptInputUserData();
            InventoryInputUserData.SerializeSwap(ctx, swapValidation.m_Src1, swapValidation.m_Src2, swapValidation.m_Dst1, swapValidation.m_Dst2, !isNotSkipped);
            validation.m_Result = InventoryValidationResult.SUCCESS;
        }
        
        return true;
    }

Перекрестные ссылки GameInventory::c_InventoryReservationTimeoutShortMS, GameInventory::c_MaxItemDistanceRadius, GameInventory::CanForceSwapEntitiesEx(), ClearInventoryReservationEx(), InventoryLocation::DumpToStringNullSafe(), EnableMovableOverride(), Error(), g_Game, GetDayZPlayerOwner(), GetInstanceType(), GetPlugin(), Debug::InventoryMoveLog(), LogManager::IsInventoryMoveLogEnable(), LogManager::IsSyncLogEnable(), InventoryLocation::IsValid(), InventoryJunctureSwapValidation::m_Dst1, InventoryJunctureSwapValidation::m_Dst2, InventoryJunctureSwapValidation::m_DstItem1, InventoryJunctureSwapValidation::m_DstItem2, InventoryValidation::m_IsJuncture, InventoryValidation::m_IsRemote, InventoryValidation::m_Reason, InventoryValidation::m_Result, InventoryJunctureSwapValidation::m_SkippedSwap, InventoryJunctureSwapValidation::m_Src1, InventoryJunctureSwapValidation::m_Src2, InventoryJunctureSwapValidation::m_SrcItem1, InventoryJunctureSwapValidation::m_SrcItem2, InventoryJunctureSwapValidation::m_Success, PlayerCheckRequestSrc(), PlayerCheckSwapItemsRequest(), RemoveMovableOverride(), SendRepairToClientDst(), InventoryInputUserData::SendServerInventoryCheck(), InventoryInputUserData::SerializeSwap(), SwapCheckExclusionMaskLocal(), syncDebugPrint(), ToString() и TryAcquireTwoInventoryJuncturesFromServer().

Используется в ProcessInputData().