ValidateSyncMove()

bool ValidateSyncMove ( inout Serializer ctx, InventoryValidation validation )

protected

kumarjac: This indicates a failure in replication relationships as player full inventory should be synchronized always if player exists on the remote

Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

kumarjac: This indicates a failure in replication relationships as player full inventory should be synchronized always if player exists on the remote

Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

Check if this this is being executed on the server and not by a juncture or AI so we can lock the item and ensure replication relationships are setup

TODO(kumarjac): We should continue with the execution and not have this special block but making a change here now will require testing

Is called twice unfortunately...

Never end here, always return in send junture part MW Do not check for action validity on remotes or when performing through juncture. Juncture locks guarentee the item is safe to interact with and the server has validated the command at this point. Checking at this point is both wasteful and can result in a failure which leads to desync

См. определение в файле DayZPlayerInventory.c строка 807

    {
        InventoryCommandType type = InventoryCommandType.SYNC_MOVE;
 
        InventoryLocation src = new InventoryLocation;
        InventoryLocation dst = new InventoryLocation;
        bool success = true;
 
        src.ReadFromContext(ctx);
        dst.ReadFromContext(ctx);
        
        #ifdef ENABLE_LOGGING
        if (LogManager.IsInventoryMoveLogEnable())
        {
            Debug.InventoryMoveLog("STS = " + GetDayZPlayerOwner().GetSimulationTimeStamp() + "src=" + InventoryLocation.DumpToStringNullSafe(src) + " dst=" + InventoryLocation.DumpToStringNullSafe(dst), "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
        }
        #endif
        
        EntityAI itemSrc = src.GetItem();
        EntityAI itemDst = dst.GetItem();
 
        if (validation.m_IsRemote && (!itemSrc || !itemDst))
        {
            
#ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - item not in bubble", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
 
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[syncinv] HandleInputData remote input (cmd=SYNC_MOVE) dropped, item not in bubble! src=" + InventoryLocation.DumpToStringNullSafe(src) + " dst=" + InventoryLocation.DumpToStringNullSafe(dst));
            }
#endif
            
            return true;
        }
 
        if (success && !validation.m_IsRemote && !validation.m_IsJuncture && itemSrc != itemDst)
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - src and dst are for different items", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
 
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[syncinv] HandleInputData Failed - src and dst are for different items src item =" + itemSrc + " dst item =" + itemDst);
            }
            #endif
 
            if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                success = false;
            }
            else
            {
                return true;
            }
        }
 
        EnableMovableOverride(itemSrc);

        if (success && !validation.m_IsRemote && !validation.m_IsJuncture && !PlayerCheckRequestSrc(src, GameInventory.c_MaxItemDistanceRadius))
        {
            
#ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - CheckRequestSrc", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
            
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[cheat] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " failed src check with cmd=" + typename.EnumToString(InventoryCommandType, type) + " src=" + InventoryLocation.DumpToStringNullSafe(src));       
            }
#endif
            
            RemoveMovableOverride(itemSrc);
            
            if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                success = false;
                #ifdef DIAG_DEVELOPER
                if (PluginInventoryDebug.Cast(GetPlugin(PluginInventoryDebug)).IsDesyncRepairEnable())
                {
                #endif
                    array<EntityAI> itemsToRepair = new array<EntityAI>;
                    InventoryLocation realIl = new InventoryLocation();
                    src.GetItem().GetInventory().GetCurrentInventoryLocation(realIl);
                    
                    if(src != realIl)
                    {
                        itemsToRepair.Insert(src.GetItem());
                        InventoryInputUserData.SendServerInventoryCheck(itemsToRepair, GetDayZPlayerOwner());
                    }   
                #ifdef DIAG_DEVELOPER
                }
                #endif
            }
            else
            {
                return true;
            }
        }
        
        if (success && !validation.m_IsRemote && !validation.m_IsJuncture && !PlayerCheckRequestDst(src, dst, GameInventory.c_MaxItemDistanceRadius))
        {
#ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - CheckMoveToDstRequest", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
 
            if (LogManager.IsSyncLogEnable())
            {
                syncDebugPrint("[cheat] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " is cheating with cmd=" + typename.EnumToString(InventoryCommandType, type) + " src=" + InventoryLocation.DumpToStringNullSafe(src) + " dst=" + InventoryLocation.DumpToStringNullSafe(dst));
            }
#endif
            
            RemoveMovableOverride(itemSrc);
            
            if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
            {
                SendRepairToClientDst(dst);
                success = false;
            }
            else
            {
                return true;
            }
        }
        
        RemoveMovableOverride(itemSrc);
        
#ifdef ENABLE_LOGGING
        if (LogManager.IsSyncLogEnable())
        {
            syncDebugPrint("[syncinv] " + Object.GetDebugName(GetDayZPlayerOwner()) + " STS = " + GetDayZPlayerOwner().GetSimulationTimeStamp() + " HandleInputData t=" + g_Game.GetTime() + "ms received cmd=" + typename.EnumToString(InventoryCommandType, type) + " src=" + InventoryLocation.DumpToStringNullSafe(src) + " dst=" + InventoryLocation.DumpToStringNullSafe(dst));
        }
#endif
    
        if (!validation.m_IsJuncture && GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
        {
            JunctureRequestResult result_mv = TryAcquireInventoryJunctureFromServer(GetDayZPlayerOwner(), src, dst);
            if (result_mv == JunctureRequestResult.JUNCTURE_NOT_REQUIRED)
            {
                #ifdef ENABLE_LOGGING
                if (LogManager.IsInventoryMoveLogEnable())
                {
                    Debug.InventoryMoveLog("Juncture not required", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                }
                #endif
                if (success)
                {
            
                    LocationSyncMoveEntity(src, dst);
 
                    validation.m_Result = InventoryValidationResult.SUCCESS;
                }
                return true;
            }
            else if (success && result_mv == JunctureRequestResult.JUNCTURE_ACQUIRED)
            {
                #ifdef ENABLE_LOGGING
                if (LogManager.IsInventoryMoveLogEnable())
                {
                    Debug.InventoryMoveLog("Juncture sended", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                }
                #endif
 
                if (!GameInventory.LocationCanMoveEntity(src, dst))
                {
                    #ifdef ENABLE_LOGGING
 
                    #ifdef DEVELOPER
                    DumpInventoryDebug();
                    #endif
 
                    if (LogManager.IsInventoryMoveLogEnable())
                    {
                        Debug.InventoryMoveLog("Failed - LocationCanMoveEntity - Juncture denied", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                    }
                    #endif
                    validation.m_Result = InventoryValidationResult.FAILED;
                    return true;
                }
                
                validation.m_Result = InventoryValidationResult.JUNCTURE;
                EnableMovableOverride(itemSrc);
                return true;
            }
            else
            {
                #ifdef ENABLE_LOGGING
                if ( LogManager.IsInventoryMoveLogEnable() )
                {
                    Debug.InventoryMoveLog("Juncture denied", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                }
                #endif
 
                validation.m_Result = InventoryValidationResult.FAILED;
                validation.m_Reason = InventoryValidationReason.JUNCTURE_DENIED;
                return true;
            }
        }
        // Check whether the juncture for the related player and items has been acquired.
        else if (validation.m_IsJuncture && GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)        
        {
            bool hasJuncture = false;
            if (itemSrc != null && itemDst != null)
            {
                hasJuncture = g_Game.HasInventoryJuncture(GetDayZPlayerOwner(), itemSrc) && g_Game.HasInventoryJuncture(GetDayZPlayerOwner(), itemDst);
            }
            else if (itemSrc != null)
            {
                hasJuncture = g_Game.HasInventoryJuncture(GetDayZPlayerOwner(), itemSrc);
            }
            else if (itemDst != null)
            {
                hasJuncture = g_Game.HasInventoryJuncture(GetDayZPlayerOwner(), itemDst);       
            }   
 
            if (!hasJuncture) 
            {
#ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - missing juncture", "SYNC_MOVE", "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
#endif
                success = false;
            }
        }
 
        if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_CLIENT)
        {
            ClearInventoryReservationEx(itemDst, dst);
        }
        
        if (success && GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER)
        {
            CheckForRope(src, dst);
        }

        if (!validation.m_IsRemote)
        {
            if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_SERVER && !GameInventory.LocationCanMoveEntitySyncCheck(src, dst))
            {
                #ifdef ENABLE_LOGGING
                        
                #ifdef DEVELOPER
                DumpInventoryDebug();
                #endif
    
                if (LogManager.IsInventoryMoveLogEnable())
                {
                    Debug.InventoryMoveLog("Failed - LocationCanMoveEntity", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                }
                #endif
                
                Error("[desync] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " CANNOT move cmd=" + typename.EnumToString(InventoryCommandType, type) + " src=" + InventoryLocation.DumpToStringNullSafe(src) + " dst=" + InventoryLocation.DumpToStringNullSafe(dst));
                return true;
            }
            else if (GetDayZPlayerOwner().GetInstanceType() == DayZPlayerInstanceType.INSTANCETYPE_CLIENT && !GameInventory.LocationTestAddEntity(dst, false, true, true, true, false, false))
            {
                #ifdef ENABLE_LOGGING
                        
                #ifdef DEVELOPER
                DumpInventoryDebug();
                #endif
    
                if (LogManager.IsInventoryMoveLogEnable())
                {
                    Debug.InventoryMoveLog("Failed - LocationCanMoveEntity", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
                }
                #endif
                
                Error("[desync] HandleInputData man=" + Object.GetDebugName(GetManOwner()) + " CANNOT move cmd=" + typename.EnumToString(InventoryCommandType, type) + " src=" + InventoryLocation.DumpToStringNullSafe(src) + " dst=" + InventoryLocation.DumpToStringNullSafe(dst));
                return true;
            }
        }
 
        
        //TODO: hotfix solution
        if (!validation.m_IsRemote && validation.m_IsJuncture && !MoveCheckExclusionMaskLocal(src,dst))
        {
            #ifdef ENABLE_LOGGING
            if (LogManager.IsInventoryMoveLogEnable())
            {
                Debug.InventoryMoveLog("Failed - MoveCheckExclusionMaskLocal - condition failed locally", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
            }
            #endif
            return false;
        }
        
        #ifdef ENABLE_LOGGING
        if (LogManager.IsInventoryMoveLogEnable())
        {
            Debug.InventoryMoveLog("Success - LocationSyncMoveEntity", "SYNC_MOVE" , "n/a", "ProcessInputData", GetDayZPlayerOwner().ToString() );
        }
        #endif
 
        if (success) 
        {
            LocationSyncMoveEntity(src, dst);
            validation.m_Result = InventoryValidationResult.SUCCESS;
        }
 
        return true;
    }

Перекрестные ссылки GameInventory::c_MaxItemDistanceRadius, CheckForRope(), ClearInventoryReservationEx(), InventoryLocation::DumpToStringNullSafe(), EnableMovableOverride(), Error(), g_Game, GetDayZPlayerOwner(), GetInstanceType(), InventoryLocation::GetItem(), GetPlugin(), Debug::InventoryMoveLog(), LogManager::IsInventoryMoveLogEnable(), LogManager::IsSyncLogEnable(), GameInventory::LocationCanMoveEntity(), GameInventory::LocationCanMoveEntitySyncCheck(), GameInventory::LocationTestAddEntity(), InventoryValidation::m_IsJuncture, InventoryValidation::m_IsRemote, InventoryValidation::m_Reason, InventoryValidation::m_Result, MoveCheckExclusionMaskLocal(), PlayerCheckRequestDst(), PlayerCheckRequestSrc(), InventoryLocation::ReadFromContext(), RemoveMovableOverride(), SendRepairToClientDst(), InventoryInputUserData::SendServerInventoryCheck(), syncDebugPrint(), ToString() и TryAcquireInventoryJunctureFromServer().

Используется в ProcessInputData().